different speeds cant be friends. Fix for #585 #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahrims
changed the title
lahrims
changed the title
tonybaloney
reviewed
Aug 23, 2024
tonybaloney
reviewed
Aug 23, 2024
tonybaloney
reviewed
Aug 23, 2024
Co-authored-by: Anthony Shaw <[email protected]>
Co-authored-by: Anthony Shaw <[email protected]>
Co-authored-by: Anthony Shaw <[email protected]>
|
@tonybaloney I see! I should have been more careful about the naming convention |
|
Is there any update on this getting merged? I'm still having this issue that this fixes as of 9/23/2024. |
|
Hi @tonybaloney |
Sorry I'm just really busy at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Issue #585
added a speed threshold and the two pet speeds are compared against the threshould for them to be friends